[PATCH] D25365: [ELF] - Do not crash on absolute local symbol starting from ".L".

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 10:38:14 PDT 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: ELF/Writer.cpp:311
 template <class ELFT>
-static bool shouldKeepInSymtab(InputSectionBase<ELFT> *Sec, StringRef SymName,
+static bool shouldKeepInSymtab(elf::ObjectFile<ELFT> *F,
+                               InputSectionBase<ELFT> *Sec, StringRef SymName,
----------------
You don't need F.


https://reviews.llvm.org/D25365





More information about the llvm-commits mailing list