[PATCH] D25132: Invoke add-discriminator at -g0 -fsample-profile

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 07:15:39 PDT 2016


dnovillo accepted this revision.
dnovillo added a comment.
This revision is now accepted and ready to land.

Thanks, Dehao.  This LGTM now.  I'm not 100% sure about the code paths in *Dwarf*.cpp, but they look safe enough.  The only concern there would be any other code that also calls getDiscriminator, in which case, perhaps we could sink the DWARF version check into getDiscriminator and have getDiscriminator return ErrorOr.


https://reviews.llvm.org/D25132





More information about the llvm-commits mailing list