[PATCH] D25368: [Object/ELF] - Do not crash on invalid Header->e_shoff value.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 07:11:35 PDT 2016


>I don't think we can be that strict with alignment, and the reason is
>gnu archives. They can put a member in a position that is only 2 bytes
>aligned.
>
>Since that changes the alignment of base(), maybe what you can do is
>check the alignment of Header->e_shoff directly?
>
>Cheers,
>Rafael

Ah, right, I have testcases failing in lld now. I`ll reimplement this.

Best regards,
George.


More information about the llvm-commits mailing list