[PATCH] D25346: [test-suite] [Polybench] run tests twice with -ffp-contract=on/off

[Sebastian Pop via llvm-commits]

sebpop added inline comments.


================
Comment at: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/2mm/2mm.c:146
+        /* FP_ABSTOLERANCE will be added to the defines when compiling this benchmark.  */
+#define FP_ABSTOLERANCE 0.0001
+        double V1 = D[i][j];
----------------
rengolin wrote:
> sebpop wrote:
> > rengolin wrote:
> > > If this has to be defined at compilation time, do we need to re-refine here? Maybe it's better to get a compilation error, to make sure the users know what they're getting.
> > This is a quick "get it done" define.  Of course, I will modify the patch to add -DFP_ABSTOLERANCE from the CMake/Makefile to the C compilation, as the previous comment suggests.
> I see. Are you adding the Makefile changes to this patch later?
Yes, if we agree that this is the way to go forward, I will finish up the patch adding for each polybench this kind of change, and the Makefiles and CMake will be amended to add -DFP_{ABS}TOLERANCE to CFLAGS.


================
Comment at: SingleSource/Benchmarks/Polybench/linear-algebra/kernels/2mm/2mm.c:208
+
+  if (check_FP(ni, nl, POLYBENCH_ARRAY(D), POLYBENCH_ARRAY(D_Strict_FP)))
+    return 1;
----------------
rengolin wrote:
> sebpop wrote:
> > rengolin wrote:
> > > Why not do this to all arrays, not just D?
> > D is the only output of this test.
> > The other arrays are input, and input does not change.
> what about the rest of the output?
Please help me here: which other output?

See the comment in the lines just below:

     All live-out data must be printed
     by the function call in argument. */

D is the only output of this benchmark (to my knowledge.)


https://reviews.llvm.org/D25346