[PATCH] D25360: [XRay] [NFC] [compiler-rt] Move machine-dependent code into machine-dependent files.

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 22:36:17 PDT 2016


dberris requested changes to this revision.
dberris added inline comments.
This revision now requires changes to proceed.


> xray_arm.cc:23
>  
> +uint64_t CycleFrequency() {
> +  static const uint64_t NanosecondsPerSecond = 1000ULL*1000*1000;

Style guide recommends functions start with lowercase letters.

> xray_arm.cc:37
> +
> +uint64_t ReadTSC(uint8_t &CPU) {
> +  timespec TS;

Same here.

https://reviews.llvm.org/D25360





More information about the llvm-commits mailing list