[PATCH] D24706: [ELF] - Partial support of --gdb-index command line option (Part 1).

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 13:17:34 PDT 2016


>There's an assertion here that the current implementation is not fast or reusable. I'm not sure where that came from or what prompted it.

>
>Could you elaborate more on why you think these things?
>
>-eric

I am not saying it is not reusable, but it definetely now do a bit more than we need in linker.
Citation of myself from one of previous mails:

"short quick example:
Imaging I want to get address ranges and so I want to use DWARFDebugInfoEntryMinimal::getAddressRanges(const DWARFUnit *U).
For doing that I need DWARFUnit, which requires DWARFContext in constructor. Looking at comments that says
"DWARFContextInMemory is the simplest possible implementation of a DWARFContext.", I am opening its constructor and
see that it takes an object and do a scan over all sections uncompresses the compressed ones. But we do not need that as we already have
content of sections available."

That this and possible other places need rework if we are want fastest solution for lld.

George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161006/a91e4633/attachment.html>


More information about the llvm-commits mailing list