[PATCH] D25300: ThinLTO: handles modules with empty summaries

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

Early comments (still working on the rest)



> tejohnson wrote in BitcodeReader.cpp:6151
> I think we should just do the addModulePath unconditionally at the top of this routine if we have an index. Then we could assert here that we have module paths. And the other places where we addModulePath would just change to assert/access.
> 
> But why is this needed if we are later going to prevent adding this to the combined index since it has an empty summary section?

> I think we should just do the addModulePath unconditionally at the top of this routine if we have an index. T

I tried this before, but I believe I ran in trouble because of the combined index: it means we'll add an entry for the combined index in the combined index itself when loading it.

> tejohnson wrote in empty_module_with_cache.ll:14
> Why do we have 1 cache entry for llvm-lto2 but 2 for llvm-lto?

We haven't hooked the cache pruning apparently.

https://reviews.llvm.org/D25300