[PATCH] D23808: [X86][SSE] Add lowering to cvttpd2dq/cvttps2dq for sitofp v2f64/2f32 to 2i32

[Simon Pilgrim via llvm-commits]

RKSimon added inline comments.


> craig.topper wrote in X86ISelLowering.cpp:22248
> What types does the FIST code below handle? Should there be a return or llvm_unreachable after the MVT::v2f32 if. I don't think the FIST code was intended for a v2i32 result type so we shouldn't fallthrough into it.

FP_TO_INTHelper only handles f32/f64/f80 scalar inputs, returning null for other inputs. https://reviews.llvm.org/rL283485 added tests to check this.

If you like I can add an early return at the end of the MVT::v2i32 block to make it clearer?

Repository:
  rL LLVM

https://reviews.llvm.org/D23808