[PATCH] D25073: [DebugInfo]: preparation to implement DW_AT_alignment

[Adrian Prantl via llvm-commits]

aprantl added a comment.

An alternative for DILocalVariable would be to stick a HasAlignment bit into Record[0] & 2, similar to how DISubprogram works. This may be simpler / more readable / more space efficient.

Do any of the bitfield tests need upgrading to remove the alignment and verify they still work?



> DIBuilder.h:209
>          DIScope *Scope, StringRef Name, DIFile *File, unsigned LineNo,
> -        uint64_t SizeInBits, uint64_t AlignInBits, uint64_t OffsetInBits,
> +        uint64_t SizeInBits, uint64_t OffsetInBits,
>          uint64_t StorageOffsetInBits, DINode::DIFlags Flags, DIType *Ty);

Have you verified that this doesn't break bitfields?

https://reviews.llvm.org/D25073