[PATCH] D25286: Ignore debug info when making optimization decisions in SimplifyCFG.

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 04:30:37 PDT 2016


jmolloy added inline comments.


> SimplifyCFG.cpp:1484
> +    } while (isa<DbgInfoIntrinsic>(I) && I != &BB->front());
> +    if (!isa<DbgInfoIntrinsic>(I))
> +      Insts.push_back(I);

You shouldn't have to check this here, because canSinkLastInstruction should have checked it.

Sidenote: I think you need to make sure it's checked in canSinkLastInstruction :)

https://reviews.llvm.org/D25286





More information about the llvm-commits mailing list