[PATCH] D25132: Invoke add-discriminator at -g0 -fsample-profile

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 18:34:56 PDT 2016


echristo added a comment.

In https://reviews.llvm.org/D25132#562990, @probinson wrote:

> In https://reviews.llvm.org/D25132#562973, @echristo wrote:
>
> >   I'm assuming the pass is only enabled when we're either a) emitting debug info, or b) going to annotate IR for samplepgo.
>
>
> Actually it looks like Clang unconditionally adds the pass and then lets the pass decide whether to do anything on its own.  I don't offhand know where LTO decides what to use for a pass pipeline.


Sure, it seems reasonable to have it added unconditionally either way for optimization purposes.

-eric


https://reviews.llvm.org/D25132





More information about the llvm-commits mailing list