[PATCH] D25132: Invoke add-discriminator at -g0 -fsample-profile

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 18:06:03 PDT 2016


echristo added a comment.

Hi Dehao,

I think if we're not going to emit them for dwarf < 4 then we don't need to plumb the sample pgo bit through the pass no? Just unconditionally add them if requested as an analysis for sample pgo to use? I'm assuming the pass is only enabled when we're either a) emitting debug info, or b) going to annotate IR for samplepgo.

Thoughts?

-eric


https://reviews.llvm.org/D25132





More information about the llvm-commits mailing list