[PATCH] D5591: AArch64: Fold immediate into the immediate field of logical instructions

[Akira Hatanaka via llvm-commits]

ahatanak added inline comments.


> ab wrote in TargetLowering.h:2278-2281
> I don't think this is the best location for this:  I'd rather have TargetLoweringOpt be "the result of an optimization", and TargetLowering be "how to do optimizations".
> 
> What do you think of going back to the TLI virtual hook, and fixing the other TLO methods to do the same:  https://reviews.llvm.org/differential/diff/73495/

I'm not sure what TargetLoweringOpt is supposed to do, but using TLI virtual hooks looks like a better approach.

https://reviews.llvm.org/D5591