[PATCH] D25132: Invoke add-discriminator at -g0 -fsample-profile

[Paul Robinson via llvm-commits]

probinson added inline comments.


> danielcdh wrote in AddDiscriminators.cpp:165
> I agree that discriminator should *not* be emitted when user specifies -gdwarf-3. But user should still be able to use -fsample-profile if they add -gdwarf-3. How about we assign discriminator early (kind of like canonicalization). But when generating code, we only emit discriminator when dwarf version is >= 4?
> 
> I've updated the patch to reflect the change.

Why analyze the CFG to create discriminators that you are not going to emit?  What value does that have?  Seems like a waste of time.

https://reviews.llvm.org/D25132