[PATCH] D25124: Support rvalue references in enumerate range adapter.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 16:34:10 PDT 2016


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM. Sorry this ended up as such a mess. Small nit below, but feel free to submit.



> STLExtras.h:629-634
> +template <typename X> struct result_pair {
> +  result_pair(std::size_t Index, X Value) : Index(Index), Value(Value) {}
> +
> +  const std::size_t Index;
> +  X Value;
> +};

I suspect this should still be in the detail namespace, and potentially still in the enumerator_impl class? Not sure when it floated out...

https://reviews.llvm.org/D25124





More information about the llvm-commits mailing list