[PATCH] D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute

[David Blaikie via llvm-commits]

I forget tmhe details exactly (like I said, drowning in too many threads,
emails, etc) - but my preference was to make the number match whatever ends
up int he DWARF. I think we're reasonably moving towards an eventual future
where we might be able to generate type descriptions in the frontend and
have the backend/middle end completely agnostic of that blob.

Changing the semantics of the field is tricky, yes - though we can rev the
bitcode version. Might not be worth it.

On Tue, Oct 4, 2016 at 9:47 AM Victor Leschuk <vleschuk at accesssoftek.com>
wrote:

> vleschuk added inline comments.
>
>
> > aprantl wrote in DIBuilder.h:139
> > What is the motivation to change this to bytes? This kind of API change
> looks dangerous to me because frontends won't even get a type error to
> notify them that the API has changed.
>
> Hmm, yep, I think you are right. I thought it would be better to pass
> bytes from frontend to backend as frontend has special CharUnits class for
> this purpose, however such changes in API can affect another frontends.
> Will change it back to bits and convert in backend.
>
> https://reviews.llvm.org/D24425
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161004/3c368b6a/attachment.html>