[PATCH] D25218: [asan] Switch to using dynamic shadow offset on iOS

Anna Zaks via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 21:27:58 PDT 2016


zaks.anna added a comment.

> Does it deserve any kind of test?

We have internal buildbots testing a majority of asan tests on iOS. With this patch, dynamic offset will be the default and all tests should still pass. (Unfortunately, our iOS test scripts will not be usable for external developers, so we keep them private.)

Dynamic shadow also works on macOS. However, to test it in CI, we'd need to add an option to TSan runtime that would force to always use dynamic shadow. It would only work on the mac or Windows. Since dynamic shadow is not needed on the mac, so I am not sure it's worth adding the complexity.


https://reviews.llvm.org/D25218





More information about the llvm-commits mailing list