Regression in object archive writer

[Dylan McKay via llvm-commits]

r276686 introduced a regression into the object archive writer.

r276686 <http://276686> on Phabricator

It causes the constructor Archive::Child(Parent, Data, StartOfFile) to
segfault if it is given a parent equalling NULL.

LLVM does this in a few places. The most prominent example is the
Archive::child_iterator default constructor. This will never execute
without causing a segfault.

I’m in the process of updating Rust to LLVM 4.0. We are currently using
Archive::child_iterator, and it causes us to segfault when writing object
files.
​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161004/f5b2692d/attachment.html>