[PATCH] D25215: [InstCombine] Transform !range metadata to !nonnull when combining loads

[Hal Finkel via llvm-commits]

hfinkel added a comment.

Please upload your patches with full context; see http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface for instructions.



> InstCombineLoadStoreAlloca.cpp:1290
>           "this code has not been auditted for volatile or ordered store case");
> -  
> +
>    BasicBlock *StoreBB = SI.getParent();

Don't commit this white-space change.

> PR30597-2.ll:1
> +; RUN: opt < %s -instcombine -S | FileCheck %s
> +

I don't see any need to have both of these tests in different files. Please put them in the same file.

> PR30597.ll:1
> +; RUN: opt < %s -instcombine -simplifycfg -S | FileCheck %s
> +

I understand why you want to run -simplifycfg here to cleanup the output of instcombine for the check, but we generally prefer to use the minimal set of passes. Please just run instcombine and check that the branch condition in the output is the appropriate constant.

Repository:
  rL LLVM

https://reviews.llvm.org/D25215