[llvm] r283169 - [lit] Remove workaround for Python 2.5

Brian Gesiak via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 17:15:37 PDT 2016


Author: modocache
Date: Mon Oct  3 19:15:37 2016
New Revision: 283169

URL: http://llvm.org/viewvc/llvm-project?rev=283169&view=rev
Log:
[lit] Remove workaround for Python 2.5

Summary:
The minimum version of Python necessary to run the LLVM test suite is
2.7. Code to work around Python 2.5 and lower isn't necessary.

Reviewers: ddunbar, echristo, delcypher, beanz

Subscribers: llvm-commits, mehdi_amini

Differential Revision: https://reviews.llvm.org/D25209

Modified:
    llvm/trunk/utils/lit/lit/main.py

Modified: llvm/trunk/utils/lit/lit/main.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/main.py?rev=283169&r1=283168&r2=283169&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/main.py (original)
+++ llvm/trunk/utils/lit/lit/main.py Mon Oct  3 19:15:37 2016
@@ -289,14 +289,7 @@ def main_with_tmp(builtinParameters):
         parser.error('No inputs specified')
 
     if opts.numThreads is None:
-# Python <2.5 has a race condition causing lit to always fail with numThreads>1
-# http://bugs.python.org/issue1731717
-# I haven't seen this bug occur with 2.5.2 and later, so only enable multiple
-# threads by default there.
-       if sys.hexversion >= 0x2050200:
-               opts.numThreads = lit.util.detectCPUs()
-       else:
-               opts.numThreads = 1
+        opts.numThreads = lit.util.detectCPUs()
 
     if opts.maxFailures == 0:
         parser.error("Setting --max-failures to 0 does not have any effect.")




More information about the llvm-commits mailing list