[PATCH] D24597: [cpu-detection] Copy simplified version of get_cpuid_max to remove dependency to clang's implementation

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 17:20:56 PDT 2016


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

OK, one inline comment.

Thanks!

-eric



> asbirlea wrote in Host.cpp:172
> There is no usage of this in llvm, clang, openmp or test-suite. However there are external tools using clang that do use the original method.
> I don't think that "__get_cpuid_max" can be removed.

OK. Can you add a comment to that effect with what you found used externally?

https://reviews.llvm.org/D24597





More information about the llvm-commits mailing list