[PATCH] D24816: [Target] move reciprocal estimate settings from TargetOptions to TargetLowering

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 17:15:56 PDT 2016


echristo added inline comments.


> TargetRecip.cpp:157
>  
> -TargetRecip::TargetRecip(const std::vector<std::string> &Args) :
> -  TargetRecip() {
> -  unsigned NumArgs = Args.size();
> +void TargetRecip::set(StringRef &RecipString) {
> +  SmallVector<StringRef, 4> RecipStringVector;

Do we still need ::set rather than just putting it as part of the constructor?

https://reviews.llvm.org/D24816





More information about the llvm-commits mailing list