[PATCH] D25172: [MSSA] Initial version of avoiding unnecessary use walks when calling getClobberingMemoryAccess

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 17:09:41 PDT 2016


george.burgess.iv added inline comments.


> MemorySSA.cpp:2185
> +  // Note: Currently, we do not store the optimized def result because we'd need
> +  // a separate field, since we can't use it as the defining access.
> +  if (StartingAccess->isOptimized())

RE: `Note: ...`: can you bring me through why having this on a Def is would be useful? Is the cache just invalidated too aggressively?

https://reviews.llvm.org/D25172





More information about the llvm-commits mailing list