[PATCH] D24167: Moving to GitHub - Unified Proposal

[Krzysztof Parzyszek via llvm-commits]

kparzysz added inline comments.


> GitHubMove.rst:355
> +Before you push, you'll need to fetch and rebase as normal.  However when you
> +fetch you'll likely pull in changes to sub-projects you don't care about.  You
> +may need to rebuild and retest, but only if the fetch included changes to a

Even with sparse checkout?  Am I going to see new files in projects that were not originally included in the sparse checkout?

> GitHubMove.rst:366
> +(almost) certainly result in a successful push. (This is
> +an extra step that you don't need in the multirepo, but for those of us who
> +work on a sub-project that depends on llvm, it has the advantage that we can

A conflicting change would have to affect the same file.  This is regardless of whether it's monorepo or multirepo.  Am I missing something here?

Rebasing is always a good practice, but it's not strictly required.  If there are no conflicts, the system will just add the change on top of the current ToT, even if they have not been fetched to the local repo.

https://reviews.llvm.org/D24167