[PATCH] D25197: [RS4GC] Handle ShuffleVector instruction in findBasePointer

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 12:29:12 PDT 2016


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/changes applied.



> RewriteStatepointsForGC.cpp:874
> +        auto *SV = cast<ShuffleVectorInst>(I);
> +        UndefValue *Vec1Undef = UndefValue::get(SV->getOperand(0)->getType());
> +        UndefValue *Vec2Undef = UndefValue::get(SV->getOperand(1)->getType());

per lang ref, these should be the same type and thus the same value.

> base-vector.ll:169
> +; identify base for shufflevector
> +define void @test8(i1 %cnd, i64 addrspace(1)* %obj, i64 %idx) gc "statepoint-example" {
> +; CHECK-LABEL: @test8

Add a test case which merges two distinct base values (i.e. arguments).

https://reviews.llvm.org/D25197





More information about the llvm-commits mailing list