[PATCH] D24168: Refactor LICM pass in preparation for LoopSink pass.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 11:53:00 PDT 2016


hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.

LGTM



> LICM.cpp:440
> +/// Returns true if the hoister and sinker can handle this instruction.
> +/// If SafetyInfo is nullptr, we are checking for sinking instruction from
> +/// preheader to loop body (no speculation).

sinking instruction from should be "sinking instructions from" or "sinking this instruction from"

https://reviews.llvm.org/D24168





More information about the llvm-commits mailing list