[PATCH] D24168: Refactor LICM pass in preparation for LoopSink pass.

Dehao Chen via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 11:26:01 PDT 2016


danielcdh added inline comments.


> chandlerc wrote in LICM.cpp:520
> (sorry, crossing replies)
> 
> I think making it more clear that the difference is between *hoisting* and *sinking* would really help. That explains the reason you don't need to call isSafeToExecuteUnconditionally at all.

Do you mean that I add a comment to the early return?

https://reviews.llvm.org/D24168





More information about the llvm-commits mailing list