[PATCH] D23808: [X86][SSE] Add lowering to cvttpd2dq/cvttps2dq for sitofp v2f64/2f32 to 2i32

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 11:14:27 PDT 2016


delena added a comment.

In https://reviews.llvm.org/D23808#558431, @craig.topper wrote:

> Elena, are you just wanting the code to be outside of the switch body in replaceNodeResults and in a separate function? I don't think it makes sense to put it into the existing LowerFP_To_SINT. That would just make that function have two different behaviors based on where its being called from.


That is the role of these Lower* functions to provide custom solution for legal and and illegal types. We do the same in LowerSINT_TO_FP(). But if you think that it does not make sense, please feel free to proceed.


Repository:
  rL LLVM

https://reviews.llvm.org/D23808





More information about the llvm-commits mailing list