[PATCH] D24816: [Target] move reciprocal estimate settings from TargetOptions to TargetLowering

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 2 19:20:57 PDT 2016

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

I think that the per-instruction metadata is a neat idea, and opens up a number of interesting and useful possibilities. However, we really should fix the current feature. This LGTM, although you should probably just address your TODO comment before committing unless there is some reason it is not trivial.

> TargetRecip.h:51
>  private:
> -  enum {
> -    Uninitialized = -1
> -  };
> -
> +  // TODO: Define 'NotEnabled' as -1 and simplify this?
>    struct RecipParams {

This TODO does not explain what this means. Do you mean using -1 RefinementSteps instead of having a separate boolean flag?

We probably should just do this, the current interface which has "true, Steps" everywhere is not aesthetically pleasing.


More information about the llvm-commits mailing list