[PATCH] D23808: [X86][SSE] Add lowering to cvttpd2dq/cvttps2dq for sitofp v2f64/2f32 to 2i32

[Craig Topper via llvm-commits]

craig.topper added a comment.

Elena, are you just wanting the code to be outside of the switch body in replaceNodeResults and in a separate function? I don't think it makes sense to put it into the existing LowerFP_To_SINT. That would just make that function have two different behaviors based on where its being called from.



> X86ISelLowering.cpp:22248
> +      }
> +    }
> +

What types does the FIST code below handle? Should there be a return or llvm_unreachable after the MVT::v2f32 if. I don't think the FIST code was intended for a v2i32 result type so we shouldn't fallthrough into it.

Repository:
  rL LLVM

https://reviews.llvm.org/D23808