[PATCH] D25138: [LIT] Add option to require PRs for XFAIL directives

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 16:10:05 PDT 2016


beanz created this revision.
beanz added reviewers: probinson, MatzeB.
beanz added a subscriber: llvm-commits.
Herald added a subscriber: mgorny.

This patch adds a new flag to lit --xfail-requires-pr which causes lit tests to fail if any XFAIL lines do not also reference a PR. To support this functionality this patch changes how XFAIL lines are parsed to allow one entry in the comma separated list to be a PR (starting with "http://llvm.org/PR").

By default this option is globally disabled in lit. It can be globally enabled by passing the flag, and it can be disabled in a test suite's lit.cfg or lit.site.cfg, using the option config.xFailRequirePR. Additionally extra PR prefixes can be specified globally using the --bug-tracker-prefix flag, or per-test suite by setting config.bugTrackerPrefixes.


https://reviews.llvm.org/D25138

Files:
  test/CMakeLists.txt
  test/ExecutionEngine/MCJIT/stubs-sm-pic.ll
  utils/lit/lit/LitConfig.py
  utils/lit/lit/Test.py
  utils/lit/lit/TestRunner.py
  utils/lit/lit/TestingConfig.py
  utils/lit/lit/main.py
  utils/lit/tests/Inputs/xfail-require-pr/lit.cfg
  utils/lit/tests/Inputs/xfail-require-pr/local-override-disable/lit.cfg
  utils/lit/tests/Inputs/xfail-require-pr/local-override-disable/xfail-suite-disabled.txt
  utils/lit/tests/Inputs/xfail-require-pr/local-override-prefix/lit.cfg
  utils/lit/tests/Inputs/xfail-require-pr/local-override-prefix/xfail-suite-custom-pr.txt
  utils/lit/tests/Inputs/xfail-require-pr/xfail-containing-custom-pr.txt
  utils/lit/tests/Inputs/xfail-require-pr/xfail-containing-pr.txt
  utils/lit/tests/Inputs/xfail-require-pr/xfail-missing-pr.txt
  utils/lit/tests/xfail-require-pr.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25138.73159.patch
Type: text/x-patch
Size: 13004 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/fd9a2df1/attachment-0001.bin>


More information about the llvm-commits mailing list