[PATCH] D24208: [WIP] MIR: Support parsing of liveins with lane masks

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 14:18:19 PDT 2016

MatzeB added a comment.

> This currently breaks some tests because currently hex constants are treated as floating point. I'm not sure what change should be made to support both, but I think it would be greatly preferable to switch to normal hex constants to be integers and only use c99 hex syntax for FP immediates

I would have wanted hex integers to fix the branch probability printing as well. However this looks tricky to solve.

I think C99 hex floats cannot represent all corner cases correctly (NaNs with payloads). However as far as I can see all instances where we want to parse hexfloats are prefixed with a keyword so we could just lex to a "hexnumber" and then interpret that as an integer or hexfloat based on context.


More information about the llvm-commits mailing list