[PATCH] D25108: Do not pass a superblock to PDBFileBuilder.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 10:19:26 PDT 2016


zturner added inline comments.


> pdbdump-readwrite.test:8
> +RUN:   | FileCheck -check-prefix=CHECK1 %s
> +RUN: llvm-pdbdump raw -headers -tpi-records %t.2 \
> +RUN:   | FileCheck -check-prefix=CHECK2 %s

Is the only difference in the two check prefixes the number of blocks?  If so I would just delete the value and leave one check statement (see the `NumDirectoryBytes` field, or the `NumStreams` field, for example.

https://reviews.llvm.org/D25108





More information about the llvm-commits mailing list