[PATCH] D25096: [RS4GC] New pass to remove gc.relocates added by RS4GC

[Anna Thomas via llvm-commits]

anna added inline comments.


> RemoveGCRelocates.cpp:60-61
> +  bool Changed = false;
> +  // All gc.relocates are bound to a single statepoint token. The order of
> +  // visiting gc.relocates for deletion does not matter.
> +  for (Instruction *GCRel : GCRelocates) {

The first line (A gc.relocate is bound to a single statepoint token) is not relevant here.

Comment should be:
The order of removing the gc.relocate does not matter, since we first make sure that *all* uses of the relocate are replaced with original pointer. After completion of this transformation for all gc.relocates, we would have the original pointer in all relocates (including nested gc.relocate).

https://reviews.llvm.org/D25096