[PATCH] [Commented On] D24996: Move UTF functions into namespace llvm.

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 07:55:58 PDT 2016


Oh, it looks like it was already taken care of in r282862.

On Fri, Sep 30, 2016 at 7:48 AM, Adrian McCarthy <amccarth at google.com>
wrote:

> I can fix up those Windows files this morning.
>
> On Fri, Sep 30, 2016 at 3:04 AM, Stefan van Kessel via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> StefanVK added a comment.
>>
>> This broke the build on windows/msvc (see http://lab.llvm.org:8011/build
>> ers/clang-x86-windows-msvc2015/builds/766)
>>
>> Host/windows/Windows.cpp
>> Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp
>> Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
>>
>> use:
>> llvm::UTF16;
>> llvm::UTF8;
>> llvm::UTF32;
>> llvm::ConversionFlags;
>> llvm::conversionOK;
>> llvm::strictConversion;
>>
>> But have no using declaration or other means of finding the moved typedefs
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D24996
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/b7eb9e55/attachment.html>


More information about the llvm-commits mailing list