[PATCH] D24480: [InstCombine] remove fold: zext(bool) + C -> bool ? C + 1 : C

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 07:43:23 PDT 2016


spatel added a comment.

There seems to be consensus that we should canonicalize towards select in IR (ie, as David suggested - https://reviews.llvm.org/rL159230 was a mistake):
http://lists.llvm.org/pipermail/llvm-dev/2016-September/105335.html
...so I will most likely abandon this patch eventually. Leaving as-is for the moment just in case that changes. And maybe we still want to make the add(zext) --> sext transform as an independent change.


https://reviews.llvm.org/D24480





More information about the llvm-commits mailing list