[PATCH] [Request, 501 lines] D25073: [DebugInfo]: preparation to implement DW_AT_alignment

Victor Leschuk via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 00:00:46 PDT 2016


vleschuk created this revision.
vleschuk added reviewers: echristo, aprantl, mehdi_amini, dblaikie.
vleschuk added a subscriber: llvm-commits.

As discussed in https://reviews.llvm.org/D24425 splitting the implementation of DW_AT_alignment into several patches. This one is a preparation that includes:

- Added alignment attribute to DIVariable family: modified DIGlobalVariable and DILocalVariable classes and their users (like DIBuilder)
- Added support for alignment in DI*Variable in bitcode. Had to perform a little workaround to support older bitcode versions (see BitcodeReader.cpp and BitcodeWriter.cpp)
- As discussed in https://reviews.llvm.org/D24425 renamed "AlignInBits" into "AlignInBytes" to match the fact that user specifies alignment in bytes in code and DWARF attribute also displays this value in bytes.


https://reviews.llvm.org/D25073

Files:
  include/llvm/IR/DIBuilder.h
  include/llvm/IR/DebugInfoMetadata.h
  lib/AsmParser/LLParser.cpp
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/DIBuilder.cpp
  lib/IR/DebugInfoMetadata.cpp
  lib/IR/LLVMContextImpl.h
  test/Assembler/diglobalvariable.ll
  test/Assembler/dilocalvariable.ll
  unittests/IR/DebugTypeODRUniquingTest.cpp
  unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25073.72987.patch
Type: text/x-patch
Size: 82068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160930/512f1aea/attachment.bin>


More information about the llvm-commits mailing list