[PATCH] D6568: DW_OP_const* is invalid as a location

[Robinson, Paul via llvm-commits]

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Katya Romanova via llvm-commits
> Sent: Wednesday, September 28, 2016 5:19 PM
> To: Romanova, Katya; dblaikie at gmail.com; echristo at gmail.com
> Cc: eugene.zelenko at gmail.com; llvm-commits at lists.llvm.org
> Subject: Re: [PATCH] D6568: DW_OP_const* is invalid as a location
> 
> kromanova added a comment.
> 
> It was committed in r224098. However, I don't see traces of it anymore. I
> need to track down if it was moved, deleted or rewritten.
> Katya.

Looks like it was moved to AddSignedConstant/AddUnsignedConstant
(in DwarfExpression.cpp) in r225734, then refactored in r265760.
The test moved to test/DebugInfo/Generic in r247775.

All still there, but the Phabricator review didn't get closed, that's all.
--paulr

> 
> 
> https://reviews.llvm.org/D6568
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits