[PATCH] D24940: [thinlto] Add cold-callsite import heuristic

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 08:37:25 PDT 2016


Downloaded latest patch from email since Phab down. LGTM with fix for test
issue that Mehdi pointed out. I don't have a strong feeling on lambda, and
Mehdi seems to be leaving that up to your preference too.

Thanks,
Teresa

On Wed, Sep 28, 2016 at 9:45 PM, Mehdi AMINI <mehdi.amini at apple.com> wrote:

> mehdi_amini added inline comments.
>
> ================
> Comment at: test/Transforms/FunctionImport/hotness_based_import.ll:32
> @@ -30,1 +31,3 @@
>
> +; RUN: opt -function-import -summary-file %t3.thinlto.bc %t.bc
> -import-instr-limit=1 -import-hot-multiplier=1.0
> -import-cold-multiplier=1.0 --S | FileCheck %s --check-prefix=CHECK
> --check-prefix=HOT-ONE
> +; HOT-COLD-ONE-DAG: define available_externally void @hot1()
> ----------------
> If this test passes, I think there's something wrong (the prefix is the
> same as the previous one...)
>
>
> https://reviews.llvm.org/D24940
>
>
>
>


-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160929/c67efb7c/attachment.html>


More information about the llvm-commits mailing list