[PATCH] D25048: Tune isHotFunction/isColdFunction

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 19:59:05 PDT 2016


eraman added a comment.

Long term we shouldn't be using the current logic (>= 0.3 * MaxFuncCount). Could you just use only  isHotCount/isColdCount and run Spec? If the performance doesn't degrade, then we can just kill the 30% or 1% of MaxFunctionCount logic. If there is a regression, we should either live with the current state of things (ie discard this patch), or move the 30%/1% logic into the inliner (and not call isHotFunction/isColdFunction.


https://reviews.llvm.org/D25048





More information about the llvm-commits mailing list