[PATCH] D24017: [LLVM] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 13:07:54 PDT 2016


mehdi_amini added a comment.

In https://reviews.llvm.org/D24017#555893, @Eugene.Zelenko wrote:

> I think it's better to be consistent with spacing.


Sure (and I really don't care about that in the end)  but:

1. Don't claim you're doing so according to the coding standard, because it is not true.
2. Different context, different rules: consistency is context-sensitive. A rule saying "include spacing for every 'long' namespace" is also consistent.


Repository:
  rL LLVM

https://reviews.llvm.org/D24017





More information about the llvm-commits mailing list