[PATCH] D25037: [compiler-rt][asan] Disable a broken test on windows 64-bits

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 12:15:12 PDT 2016


etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, llvm-commits.
Herald added subscribers: dberris, kubabrecka.

This test is broken on wndows 64-bit.

The interception library is not able to hook on the memchr functions.

https://reviews.llvm.org/D25037

Files:
  test/asan/TestCases/Windows/dll_intercept_memchr.cc

Index: test/asan/TestCases/Windows/dll_intercept_memchr.cc
===================================================================
--- test/asan/TestCases/Windows/dll_intercept_memchr.cc
+++ test/asan/TestCases/Windows/dll_intercept_memchr.cc
@@ -2,6 +2,12 @@
 // RUN: %clang_cl_asan -LD -O0 %s -Fe%t.dll
 // RUN: not %run %t %t.dll 2>&1 | FileCheck %s
 
+// On windows 64-bit, the memchr function is written in assembly and is not
+// hookable with the interception library. There is not enough padding before
+// the function and there is a short jump on the second instruction which
+// doesn't not allow enough space to encode a 64-bit indirect jump.
+// UNSUPPORTED: x86_64-windows
+
 #include <string.h>
 
 extern "C" __declspec(dllexport)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25037.72874.patch
Type: text/x-patch
Size: 742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160928/00aa2ca3/attachment.bin>


More information about the llvm-commits mailing list