[PATCH] D24492: [LTO] Switch to the new resolution-based API.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 11:47:44 PDT 2016


pcc added inline comments.

================
Comment at: lld/ELF/LTO.cpp:154
@@ +153,3 @@
+  for (unsigned I = 0; I != MaxTasks; ++I) {
+    if (!Buff[I].empty()) {
+      // Do we want to move this to the LTO API?
----------------
davide wrote:
> hmm, I still need `I` to be passed to saveBuffer, no? Do you want me to use a separate variable incremented at each iteration?
No, sorry, what you have is fine.

================
Comment at: lld/ELF/LTO.cpp:155
@@ +154,3 @@
+    if (!Buff[I].empty()) {
+      // Do we want to move this to the LTO API?
+      if (Config->SaveTemps) {
----------------
I would remove this comment as it doesn't help readers understand the code.


https://reviews.llvm.org/D24492





More information about the llvm-commits mailing list