[PATCH] D23155: Power9 - Part-word VSX integer scalar loads/stores and sign extend instructions

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 08:20:16 PDT 2016


nemanjai added inline comments.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:10300
@@ -10317,1 +10299,3 @@
 
+  SDValue FirstOperand(Op.getOperand(0));
+  bool SubWordLoad = FirstOperand.getOpcode() == ISD::LOAD &&
----------------
kbarton wrote:
> Was this new section formatted with clang-format?
> The indentation looks strange to me, but this might be what it does when you have these types of long lines.
Yeah. Well I use Vim and the provided .vimrc which indents things according to the policy. It will line up the conditions when they're parenthesized (i.e. in an if statement). But for an assignment/initialization, it indents the continued lines 1 tab stop (2 spaces) from the indentation of the declarator.


Repository:
  rL LLVM

https://reviews.llvm.org/D23155





More information about the llvm-commits mailing list