[PATCH] D24987: [ELF] Use MaxPageSize for aligning PT_LOAD

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 15:12:40 PDT 2016


On 27 September 2016 at 14:35, Petr Hosek <phosek at google.com> wrote:
> phosek added a comment.
>
> The question is whether it wouldn't also make more sense to rename `MaxPageSize` and `PageSize` to something more descriptive/less confusing, e.g. gold uses `abi_pagesize` (for `MaxPageSize`) and `common_pagesize` (for `PageSize`) which IMHO makes more sense.

We normally name stuff for the command line they map to.

Cheers,
Rafael


More information about the llvm-commits mailing list