[PATCH] D24638: [thinlto] Basic thinlto fdo heuristic

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

I'm not sure this is correct, see inline.


================
Comment at: llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp:291
@@ +290,3 @@
+        Edge.second.Hotness == CalleeInfo::HotnessType::Hot
+            ? Threshold * ImportHotMultiplier
+            : Threshold;
----------------
This does not seem correct to me. The multiplier should be apply only on the initial "seed" of the call chain, not at every chain.

================
Comment at: llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp:368
@@ -358,3 +367,3 @@
     DEBUG(dbgs() << "Initalize import for " << GVSummary.first << "\n");
     computeImportForFunction(*FuncSummary, Index, ImportInstrLimit,
                              DefinedGVSummaries, Worklist, ImportList,
----------------
Here the `ImportInstrLimit` can benefit of the multiplier.


Repository:
  rL LLVM

https://reviews.llvm.org/D24638