[PATCH] D24974: Add build script for symbolizer which can be linked into instrumented process.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh:61
@@ +60,3 @@
+
+# libc++abi can't be built without exceptions or rtti
+ZLIB_BUILD=${BUILD_DIR}/zlib
----------------
this comment does not make sense

================
Comment at: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh:68
@@ +67,3 @@
+FLAGS=${FLAGS:-}
+FLAGS="$FLAGS -w -fPIC -flto -Os -g0 -fno-exceptions -DNDEBUG"
+
----------------
please remove -w

================
Comment at: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh:132
@@ +131,3 @@
+for F in `find ${BUILD_DIR} -type f -regex .*\\\\.o$`; do
+  ( ($LINK $F -o $(mktemp XXXXXX.o) 2>/dev/null) || (echo "skipping non-llvm: $F") ) &
+done
----------------
this looks fragile
is it possible to unpack LLVM*.a instead?

================
Comment at: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh:137
@@ +136,3 @@
+FLAGS="$FLAGS -std=c++11 -I${LLVM_SRC}/include -I${LLVM_BUILD}/include"
+$CXX $FLAGS ${SRC_DIR}/sanitizer_symbolize.cc ${SRC_DIR}/sanitizer_wrappers.cc -c
+
----------------
the build should use sanitizer_symbolizer_hooks.cc in some way


https://reviews.llvm.org/D24974