[PATCH] D24891: [ELF] Support -z max-page-size option

[Davide Italiano via llvm-commits]

davide added a comment.

In https://reviews.llvm.org/D24891#553952, @phosek wrote:

> This is getting more complicated, I was looking at using `-z max-page-size` and `-z common-page-size` values in the `Writer` and found that lld's use of page size is somewhat inconsistent so I filed a bug 30541 <https://llvm.org/bugs/show_bug.cgi?id=30541> and proposed possible solutions. It'd be great to decide on the solution for the page size handling before landing this patch as it might require further changes (e.g. if we decide to only use the maximum page size, we probably shouldn't accept the `-z common-page-size` flag).


Slightly related. There were problems in the past because lld was aliasing MAXPAGESIZE and PAGE_SIZE on x86-64 and this caused the FreeBSD kernel to crash when linked with lld so I want to be sure that configuration is tested when experimenting with page sizes. I assume that if we mimic what bfd does we should be OK in that case, as the kernel is currently linked with a very old (2.17) version of it.


https://reviews.llvm.org/D24891