[PATCH] D24950: Add xxhash to llvm

[Davide Italiano via llvm-commits]

davide added a subscriber: davide.
davide added a comment.

Can you add a couple of tests?


================
Comment at: llvm/tools/llvm-xxhash/CMakeLists.txt:1
@@ +1,2 @@
+set(LLVM_LINK_COMPONENTS
+  Support
----------------
Can you double check this works with SHARED_LIBS?

================
Comment at: llvm/tools/llvm-xxhash/llvm-xxhash.cpp:1
@@ +1,2 @@
+//===-- llvm-ar.cpp - LLVM archive librarian utility ----------------------===//
+//
----------------
hmm, typo?

================
Comment at: llvm/tools/llvm-xxhash/llvm-xxhash.cpp:20
@@ +19,3 @@
+  if (argc != 2) {
+    errs() << "filename is required\n";
+    exit(1);
----------------
print argv[0] while you're here? or usage?


https://reviews.llvm.org/D24950