[PATCH] D24891: [ELF] Support -z max-page-size option

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 15:09:29 PDT 2016


phosek updated this revision to Diff 72573.
phosek marked 3 inline comments as done.
phosek added a comment.

I was checking the behavior of both BFD ld and gold. BFD ld checks whether the argument is power of 2 while gold doesn't, but I don't see any reason why page size wouldn't be a power 2 so I've added that check as well. The handling of common-page-size is strange, there doesn't seem to be a clear consensus on how exactly that value should be interpreted.


https://reviews.llvm.org/D24891

Files:
  ELF/Config.h
  ELF/Driver.cpp
  ELF/LinkerScript.cpp
  test/ELF/linkerscript/zcommon-page-size.s
  test/ELF/linkerscript/zmax-page-size.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24891.72573.patch
Type: text/x-patch
Size: 5128 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160926/f3b866fa/attachment.bin>


More information about the llvm-commits mailing list